search

yosbelms / react-progressive-loader

Utility to load images and React components progressively, and get code splitting for free
217 stars 12 forks source link

do we really need to use react-deco? #8

Open felixmosh opened 5 years ago

felixmosh commented 5 years ago

First of all, thank you for this awesome lib!

This lib can be ~50% smaller by removing the dep on react-deco.

image If you agree I will create a PR for that.

yosbelms commented 5 years ago

@felixmosh react-deco is the responsible of the 33.1% of the weight of this library. I wonder how smaller it will be, regarding typescript adds headers for classes and stub for method definitions when compiling to ES5, and both (Image and Defer) components are stateful.

I need more votes for this issue. Though, I'm curious to know how smaller it will be.

yosbelms commented 4 years ago

@felixmosh I think it is time to reopen this issue now that React hooks are adopted by the community we can get rid of react-deco PR is welcome!