yosefHesham / TvMaze-Capstone

Movies website that keep you updated with the top rated and most popular movies
https://unrivaled-alfajores-11e018.netlify.app/
4 stars 0 forks source link

Kanban board #21

Open yosefHesham opened 2 years ago

yosefHesham commented 2 years ago

Hey reviewer :handshake: , I hope you are doing great here is our project :arrow_down:

https://github.com/yosefHesham/TvMaze-Capstone/projects/3

We are 2 people

ShadyShawkat commented 2 years ago

Hi Team,

Good job so far! 👍🏻 There are some issues that you still need to work on to go to the next project but you are almost there!

Image

Required Changes ♻️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new issue for re-reviews. You should use the same issue submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

yosefHesham commented 2 years ago

its already assigned image

Hi Team,

Good job so far! 👍🏻 There are some issues that you still need to work on to go to the next project but you are almost there!

Image Image

Required Changes

  • [ ] Kindly make sure that all the tasks have at least one team memeber assigned to it, even if it's a group task. image

Cheers and Happy coding!clapclapclap

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new issue for re-reviews. You should use the same issue submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

hey @ShadyShawkat its already assigned image

Mihndim2020 commented 2 years ago

STATUS: APPROVED!!! 🎉 🎉 🎉 :champagne: :champagne: :champagne:

Hi Team,

Your project is complete! Great work on making the changes requested by the previous reviewer. There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉 🎉 🎉 :champagne: :champagne: :champagne:

Congratulations-Memes-FEATURED

Optional suggestions

Check the comments under the review.

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

ShadyShawkat commented 2 years ago

Kindly look at the image attached. There are unassigned group tasks.

yosefHesham commented 2 years ago

done @ShadyShawkat you are right i didn't see well :D