yoshida-lab / XenonPy

XenonPy is a Python Software for Materials Informatics
http://xenonpy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
133 stars 57 forks source link

bug in set_para for BaseDescriptor #153

Closed stewu5 closed 4 years ago

stewu5 commented 4 years ago

set_para will not function properly in BaseDescriptor because the values assigned will not pass to BaseFeaturizers inside. E.g., when setting on_errors with .set_para in BaseDescriptor, the on_errors actually will not pass to the BaseFeaturizers defined inside. A new def for set_para in BaseDescriptor is needed