yoshida-lab / XenonPy

XenonPy is a Python Software for Materials Informatics
http://xenonpy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
139 stars 61 forks source link

Update modifier.py #232

Closed stewu5 closed 3 years ago

stewu5 commented 3 years ago

ngram_tab to ngram_table in init

codecov[bot] commented 3 years ago

Codecov Report

Merging #232 (382f3aa) into master (8f9ac53) will increase coverage by 58.14%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #232       +/-   ##
===========================================
+ Coverage   35.30%   93.44%   +58.14%     
===========================================
  Files          95       26       -69     
  Lines        6868     2595     -4273     
===========================================
  Hits         2425     2425               
+ Misses       4443      170     -4273     
Impacted Files Coverage Δ
xenonpy/utils/useful_cls.py
xenonpy/utils/math/__init__.py
xenonpy/utils/math/product.py
xenonpy/model/nn/wrap.py
xenonpy/inverse/iqspr/iqspr.py
xenonpy/model/training/extension/validator.py
xenonpy/descriptor/cgcnn.py
xenonpy/contrib/ismd/reactant_pool.py
xenonpy/model/sequential.py
xenonpy/model/cgcnn.py
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f9ac53...c368142. Read the comment docs.

stewu5 commented 3 years ago

Code sounds good. And don't forget to activate the skipped test cases.

can you hightlight the part i needed to delete?

also, seems like one check failed?

TsumiNa commented 3 years ago

@stewu5 Remove the skip annotation in these lines: https://github.com/yoshida-lab/XenonPy/blob/382f3aa951df3e4020f040916039bec639cb0e4e/tests/inverse/test_iqspr.py#L134-L137

The failed test come from GitHub's infrastructure. Seems the infrastructure of MacOS has some problems recently.