yoshida-lab / XenonPy

XenonPy is a Python Software for Materials Informatics
http://xenonpy.readthedocs.io
BSD 3-Clause "New" or "Revised" License
131 stars 57 forks source link

Add "only_best_status" option to Persist #233

Closed TsumiNa closed 3 years ago

TsumiNa commented 3 years ago

This option enables Persist to only save the best states of each criterion

codecov[bot] commented 3 years ago

Codecov Report

Merging #233 (48074c4) into master (d504a1f) will increase coverage by 58.02%. The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #233       +/-   ##
===========================================
+ Coverage   35.46%   93.49%   +58.02%     
===========================================
  Files          95       26       -69     
  Lines        6868     2644     -4224     
===========================================
+ Hits         2436     2472       +36     
+ Misses       4432      172     -4260     
Impacted Files Coverage Δ
tests/models/test_extension.py 94.73% <75.00%> (-3.81%) :arrow_down:
...riptors/descriptor/frozen_featurizer_descriptor.py
xenonpy/contrib/ismd/reactant_pool.py
xenonpy/utils/math/__init__.py
xenonpy/model/sequential.py
xenonpy/utils/useful_cls.py
xenonpy/model/training/base.py
xenonpy/model/nn/wrap.py
xenonpy/model/utils/__init__.py
xenonpy/_conf.py
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d504a1f...0644331. Read the comment docs.

TsumiNa commented 3 years ago

@stewu5 Could you please check the docs for the new option? Also, the codes if you have any comment.