Scaler transform or fit functions are actually all becoming fit_transform

yoshida-lab / XenonPy

XenonPy is a Python Software for Materials Informatics

http://xenonpy.readthedocs.io

BSD 3-Clause "New" or "Revised" License

131 stars 57 forks source link

Scaler transform or fit functions are actually all becoming fit_transform #243

Closed stewu5 closed 2 years ago

stewu5 commented 2 years ago

Currently in the Scaler class, both transform and fit functions are actually operating "fit_transform", which is a problem especially for the transform case because unintentional fitting will occur.

TsumiNa commented 2 years ago

@stewu5 Good catch! could you create a new PR to fix this error?