search

yoshidan / google-cloud-rust

Google Cloud Client Libraries for Rust.
MIT License
233 stars 85 forks source link

GCS: support single byte resumable upload #129

Closed danburkert closed 1 year ago

danburkert commented 1 year ago

Fixes an issue in ChunkSize which previously made it impossible to use resumable uploads to upload an object of length 1.

yoshidan commented 1 year ago

Due to the change in the calculation of ChunkSize, the Content-Length in the status method is not zero and the response is not returned. it would be better to modify the status method to not do ChunkSize. https://github.com/yoshidan/google-cloud-rust/blob/cbd5ed1315d7b828c89a50fe71fcbaf15ddc964b/storage/src/http/resumable_upload_client.rs#L109

https://github.com/yoshidan/google-cloud-rust/blob/cbd5ed1315d7b828c89a50fe71fcbaf15ddc964b/storage/src/http/storage_client.rs#L2022

danburkert commented 1 year ago

Should be ready to test again.