search

yoshidan / google-cloud-rust

Google Cloud Client Libraries for Rust.
MIT License
216 stars 81 forks source link

Allowing constructing CredentialsFile from string #201

Closed benjaminch closed 9 months ago

benjaminch commented 9 months ago

PR aiming to tackle issue described here: https://github.com/yoshidan/google-cloud-rust/issues/200

yoshidan commented 9 months ago

Please run 

cargo clippy --fix
cargo fmt

to fix CI.

benjaminch commented 9 months ago

Oupsie ! Fixing it now :)

benjaminch commented 9 months ago

done !

yoshidan commented 9 months ago

Overriding environment variables cause other tests to fail. In the scope of your addition, only test_credentials_file_new_from_str is sufficient as a test, so could you please remove the other tests, leaving only test_credentials_file_new_from_str for the time being? I would appreciate it if you could delete the other tests.

benjaminch commented 9 months ago

Hey @yoshidan ! Would it be ok to use a dedicated env var crates tackling those challenges? It will allow to set env vars, test it without any issue having tests running in parallel?

It allows to keep tests on this part :)

Cheers

yoshidan commented 9 months ago

Thanks!

benjaminch commented 9 months ago

Hey @yoshidan ! Would you mind creating a new release with this change? Thanks a lot :)

yoshidan commented 8 months ago

Hi @benjaminch I published new release now.