search

yoshidk6 / rstanemax

Simple Emax model fit with Stan
https://yoshidk6.github.io/rstanemax/
GNU General Public License v3.0
5 stars 1 forks source link

Update compatibility for future rstan #43

Closed andrjohns closed 2 years ago

andrjohns commented 2 years ago

Hi,

This PR adds the changes to build flags that are needed for compatibility with the upcoming release of rstan. These changes include adding compiler & linker flags needed for working with StanHeaders >= 2.26, namely the addition of the TBB (RcppParallel).

Additionally, this PR adds a compiler flag to your Makevars files which is needed for compatibility with the upcoming version of rstan: -DUSE_STANC3

The Stan-to-c++ transpiler (stanc) was refactored after 2.21, and so different c++ is used in the new rstan package (>= 2.26). Because of this, the flag -DUSE_STANC3 needs to be added when a stan model is being run using the new rstan package (and the new stanc implementation).

Feel free to let me know if you need any more info.

Thanks! Andrew

yoshidk6 commented 2 years ago

Thank you Andrew! Truly appreciate your proactive engagement. It seems like the package installation failed in Mac/Ubuntu environments, while it looks fine on Windows. Is this something specific to this package or do you see this for any other packages that depend on rstan? I'm not very familiar with compiler settings, any help would be appreciated!

andrjohns commented 2 years ago

Ah sorry about that, I forgot to set the configure files as executable which causes a build error on linux and mac. I've made that change now

yoshidk6 commented 2 years ago

Thank you @andrjohns . How would you like to be added as a contributor (e.g. full name, ORCID)?