yoshiharuyamashita / blackburn

A Hugo theme built using Yahoo's Pure CSS
MIT License
317 stars 170 forks source link

Images missing max-width property #68

Closed paskal closed 6 years ago

paskal commented 6 years ago

Hello!

I've stumbled upon the issue exactly the same as https://github.com/dim0627/hugo_theme_beg/issues/19: image

Source code:

![Shinken simple distributed architecture](https://shinken.readthedocs.io/en/latest/_images/shinken-architecture.png)
yoshiharuyamashita commented 6 years ago

Hi @paskal

Does wrapping your image using fluid_imgs fix the problem? Take a look at this for usage.

paskal commented 6 years ago

It could fix the problem but it won't change the fact standard ![image_alt_text](image_link) is rendered improperly.

nonumeros commented 6 years ago

@paskal the only md engine I'm aware of (there may be others out there though) is https://github.com/gettalong/kramdown which would let you have ![alt name](image link){:width=dim height=dim} You should ask the hugo devs

See https://github.com/takuti/takuti.me/blob/master/_content/note/hugo-markdown-and-mathjax.md

paskal commented 6 years ago

Guys, guys, it's as simple as https://github.com/dim0627/hugo_theme_beg/commit/7718359506a2447ef0489dcd6bd7360f21eb93cb

nonumeros commented 6 years ago

Guys, guys, it's as simple as dim0627/hugo_theme_beg@7718359

You're right.... for max-width you have a pure-img-responsive on fluids_images.html.... So replacing the .pure-img-responsive on side-menu.css seems to resolve it.

yoshiharuyamashita commented 6 years ago

Perhaps would it not be better to create your own custom css with the fix and use it with custom_css?

paskal commented 6 years ago

Create my own custom_css to get generic markdown syntax properly rendered? I've got you.

nonumeros commented 6 years ago

@paskal thanks for bringing it up. If you were to modify ( as per your suggestion with https://github.com/dim0627/hugo_theme_beg/commit/7718359 ), side-menu.css 's pure-img-responsive with something as simple as img , further changes on this theme are still required.

Try it out... It would render momentarily.

I think other hugo themes may benefit from your finding. I'll reference you accordingly.