search

yoshiharuyamashita / blackburn

A Hugo theme built using Yahoo's Pure CSS
MIT License
317 stars 170 forks source link

Fix expansion of submenu #79

Closed josephting closed 6 years ago

josephting commented 6 years ago

Sub-menu was not working as expected. Changes below has been made:

  1. Add .pure-menu-link to children menus for layout uniformity
  2. overflow-y removed from #menu so submenu can show up without scrolling the menu horizontally to see submenu
  3. #menu a to have right padding restored for submenu link layout
  4. Remove top border of ul for submenus
  5. Add JavaScript as recommended by PureCSS - example script

Closes #74

yoshiharuyamashita commented 6 years ago

Thank you @josephting for fixing this problem.

If possible, I would like to avoid making any changes to those files (they are from https://purecss.io/layouts/side-menu/download). I wonder, if you could move your changes to custom files instead please?

Many thanks

Yoshi

josephting commented 6 years ago

Sure thing. I've moved the styles to blackburn.css and created a new file for the javascript.

yoshiharuyamashita commented 6 years ago

That’s grand, thanks @josephting !