yoshiki / yaml-mode

The emacs major mode for editing files in the YAML data serialization format.

GNU General Public License v3.0

482 stars 132 forks source link

fix: #96 highlight error with inline comments #98

Closed liuyinz closed 1 year ago

liuyinz commented 2 years ago

@wasamasa please check it

liuyinz commented 1 year ago

Is there any maintainer for the project now ? Several months have passed.. @syohex @wasamasa

syohex commented 1 year ago

I'm afraid that I don't have any permissions of this repository

liuyinz commented 1 year ago

Sorry, I make a mistake here. @yoshiki please check it

yoshiki commented 1 year ago

Thankfully, @wasamasa is currently doing most of the maintenance. I have not been able to get involved in most of it.

@syohex I apologize for the sudden request. If you are interested and able to collaborate, would you join us as one of the maintainers?

syohex commented 1 year ago

@yoshiki Thanks, sure. I would check issues when I have free time. Please feel free to give me repository permissions.

wasamasa commented 1 year ago

I've been pretty busy the last few months, sorry about that. Doesn't look like it will get better soon. Therefore, I do welcome @syohex aboard. That being said, there's a few things to be kept in mind:

Non-trivial contributions require copyright assignment to not impede the GNU ELPA ticket (see #44)
Non-trivial changes require a YAML test file that allows easily checking whether the issue has indeed been fixed and whether future changes break it again
There's a release process and the Debian package depends on it being done correctly (see https://github.com/yoshiki/yaml-mode/commit/fc5e1c58f94472944c4aa838f00f6adcac6fa992 for an example commit)

@liuyinz The regex could be simplified by changing to \\b because what you're really trying to do is match a word boundary, not end of line or spaces.

yoshiki commented 1 year ago

@syohex Thank you for your cooperation. I just invited you to the maintainer of this repository. Please check it. Of course, it's ok to check issues when you have time. 😄

@wasamasa Thanks again for all your support. Please keep up the good support with the new maintainer @syohex.

syohex commented 1 year ago

Non-trivial contributions require copyright assignment to not impede the GNU ELPA ticket (see https://github.com/yoshiki/yaml-mode/issues/44)

I have already sent copyright assignment to GNU

syohex commented 1 year ago

@liuyinz , @wasamasa I sent PR #101 which includes this change. Please check it.

liuyinz commented 1 year ago

101 fixed. @syohex, I'll closed this pr