yoshinorim / mha4mysql-manager

Development tree of Master High Availability Manager and tools for MySQL (MHA), Manager part
http://code.google.com/p/mysql-master-ha/
GNU General Public License v2.0
1.47k stars 501 forks source link

Super read only support #56

Closed grypyrg closed 6 years ago

grypyrg commented 8 years ago

This adds functionality for super_read_only which is in Percona Server & MariaDB. Certain tests are done while the node might still be in read_only, this code disables the super_read_only (and enables read_only) during the tests and during the applying of relay logs.

gcs-github commented 8 years ago

Looks very interesting.

Can I ask why you decided to remove the engine spec when creating the infra.chk_masterha table? Seems it could be a way to introduce weird problems if one was to work with an esoteric default-storage-engine option.

grypyrg commented 8 years ago

@gcs-github If you use enforce_storage_engine=innodb (percona server / mariadb) then you get an error while creating a MyISAM table. See commit df1f5e7

grypyrg commented 6 years ago

@yoshinorim : Would you please consider merging this PR or provide feedback about it? There has been an uptick in requests to have super_read_only support with MHA.