yoshinorim / mha4mysql-manager

Development tree of Master High Availability Manager and tools for MySQL (MHA), Manager part
http://code.google.com/p/mysql-master-ha/
GNU General Public License v2.0
1.47k stars 501 forks source link

allow ipv4 addresses (revert part of 35b3d9b) #69

Closed ktat closed 6 years ago

ktat commented 8 years ago

ipv4 address with brackts causes error on connection. add brackets only when ip contains ':'.

ktat commented 8 years ago

Sorry. my using DBD::mysql version is dev version (4.033_2) and it causes error on connection, but I confirmed ipv4 with brackets causes no error at least DBD::mysql version 4.033.

But, if you require newer DBD::mysql only for ipv6 adress, please apply this patch and change required DBD::mysql version to older one.

grypyrg commented 6 years ago

Related to #61.

grypyrg commented 6 years ago

I made a few more changes to this PR and made a new PR on #94.