search

yoshuawuyts / barracks

:mountain_railway: action dispatcher for unidirectional data flows
MIT License
177 stars 22 forks source link

noSubscriptions: true -> subscriptions: false ? #40

Closed timwis closed 8 years ago

timwis commented 8 years ago

I feel like I read somewhere that having negative params like the former is less readable/obvious than the latter (no + true = false). Just a suggestion as you're finalizing the API. Don't mean to cause more trouble!

yoshuawuyts commented 8 years ago

hmmm, no I think you're right, doing store.start({ subscriptions: false }) seems like a better API haha - I'm quite sure I had a reason for it but I'm tired right now so I'll revisit tomorrow - def thanks for raising it tho! :sparkles: