search

yoshuawuyts / barracks

:mountain_railway: action dispatcher for unidirectional data flows
MIT License
177 stars 22 forks source link

fix(start): pass state and createSend to onError hook #71

Closed finnp closed 8 years ago

finnp commented 8 years ago

Hey,

I noticed that the state and createSend was actually not available in the on error hook. Added it, and now it works ☺️

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 98.6% when pulling 5b9211993ae6a3bdedbd305ec766e09c44bb7b93 on finnp:onerror into 483955952d700d6c567d0b2f86cb8035dddacce6 on yoshuawuyts:master.

finnp commented 8 years ago

There seems to be an issue on choo for this, closes https://github.com/yoshuawuyts/choo/issues/142

YerkoPalma commented 8 years ago

Isn't this the same as #49 ?

finnp commented 8 years ago

Nope the change from #49 is already implemented here https://github.com/yoshuawuyts/barracks/commit/0064e6a048ff53521f56a481c27322e12f8fd01f. However the arguments are missing at this place as well.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.006%) to 98.606% when pulling 941f5609d98ae92754f0fc537cc4173a10bf267a on finnp:onerror into 483955952d700d6c567d0b2f86cb8035dddacce6 on yoshuawuyts:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.006%) to 98.606% when pulling 941f5609d98ae92754f0fc537cc4173a10bf267a on finnp:onerror into 483955952d700d6c567d0b2f86cb8035dddacce6 on yoshuawuyts:master.