search

yoshuawuyts / futures-concurrency

Structured concurrency operations for async Rust
https://docs.rs/futures-concurrency
Apache License 2.0
414 stars 33 forks source link

Declare minimum support rust version in Cargo manifest #180

Closed Awfa closed 7 months ago

Awfa commented 7 months ago

Today, this crate doesn't declare the msrv in the Cargo.toml.

This can lead to more confusing errors when trying to compile with an older Rust compiler, and when trying to find the right release that would work with an older Rust compiler.

This would likely need a pipeline change as well, so the CI verifies the declared msrv. There seems to be notes on that here.

matheus-consoli commented 7 months ago

hi @Awfa, i think we should definitely do it, thanks for pointing this out!