yoshuawuyts / microcomponent

Smol event based component library
MIT License
35 stars 11 forks source link

3.1.5 → 3.1.6 introduced bug #28

Open martinheidegger opened 6 years ago

martinheidegger commented 6 years ago

I am trying to debug a problem in dat-desktop where the "empty" screen of the development branch suddenly looked weird and I was able to track this back to the update of mircocomponent.

BEFORE Version 3.1.5 (released as Dat Desktop 2.0.0)

screen shot 2018-01-17 at 17 32 18

AFTER Version 3.1.6

Dat Desktop with microcomponent 3.1.6

Here is the diff from the package-lock.json between the screenshots.

diff --git a/package-lock.json b/package-lock.json
index 111a0a2..a26ba34 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -6439,9 +6439,9 @@
       }
     },
     "microcomponent": {
-      "version": "3.1.5",
-      "resolved": "https://registry.npmjs.org/microcomponent/-/microcomponent-3.1.5.tgz",
-      "integrity": "sha1-WQgEhQmJ+t9W0xzUoSImd2WKDZ4=",
+      "version": "3.1.6",
+      "resolved": "https://registry.npmjs.org/microcomponent/-/microcomponent-3.1.6.tgz",
+      "integrity": "sha1-C9QBOlcEJCHscGbU2OYKx2v99Ms=",
       "requires": {
         "juliangruber-shallow-equal": "1.0.4",
         "nanocomponent": "5.0.3",

I am not familiar with microcomponent (or choo) and this is hard for me to debug. 😓 Any help would be welcome.

yoshuawuyts commented 6 years ago

This package hasn't been maintained for a while, I believe you might want to look into https://github.com/choojs/nanocomponent instead.

Also https://github.com/datproject/dat-desktop/pull/450 might solve some of you problems too. Might be cool to link up with @aks- :sparkles:

martinheidegger commented 6 years ago

Thanks for letting me know.