yosinch / editing

document.execCommand in JavaScript for Blink
4 stars 6 forks source link

Remove extern/editing_typedefs.js #1

Closed ghost closed 10 years ago

ghost commented 10 years ago

This file seems to have been replaced by node_extern.js.

By removing this, java -jar /path/to/compiler.jar --language_in=ECMASCRIPT6 --language_out=ECMASCRIPT3 --js *.js commands/*.js externs/*.js testing/*.js can be passed. However, we need to fix the files more in order to pass the tests with the type checking --jscomp_error=checkTypes

yosinch commented 10 years ago

Sorry for long day. editing_typedefs.js is an intermediate file and should not be in repository.

I run closure compiler via checker.cmd + checker.py by file by file, rather than shell glob, since I work on Windows.

Note: I should update checker.py to take path to compiler.jar. It should be upload soon.

ghost commented 10 years ago

Do you have a plan to create a shell script of checker working on Linux instead of Windows, or is there already a way to execute the checker on Linux?

yosinch commented 10 years ago

I have no plan to make linux tools. Please make linux tools. Thanks in advance.