yosoyubik / canvas

Peer-to-peer paint app for Urbit
MIT License
142 stars 9 forks source link

Advanced Coloring Part 1 #24

Closed johnhyde closed 2 years ago

johnhyde commented 2 years ago

Done:

Todo:

yosoyubik commented 2 years ago

This is insanely cool! Super grateful that you took the time to work on this.

eraser (dedicated 0-alpha brush, for those who want it)

Yes, because it was not obvious that you can already do that by clicking/dragging with the same color selected—I saw big chunks of white on the public canvas.

Some comments:

I noticed an issue with the fill-tool (pasting it here to keep track of it):

Screen Shot 2021-12-06 at 9 13 26 AM

Tell the user about the shortcuts somehow (help menu? tooltip on hover?)

We can update the "Welcome Message" tooltip and add them there.

Create a box to display the currently selected color

Yes, this would be very useful. I'm thinking that we can replace what I had currently for the "last used color" (just a black square around one of the 18 visible colors) and update the box/square when:

Wondering what the best place to put it—I can imagine a version where only the active color is shown, but when you click on it, it expands showing you the last N colors—but maybe next to the 18 we have visible now?

Added keyboard shortcuts for tools

I noticed that Brave entered into caret mode sometimes, not sure if there's a way to detect that and tell the user? I managed to get it working by turning it on/off but otherwise you might go to the previous page you've visited...

Again, this is awesome :) :) Thanks!

johnhyde commented 2 years ago

Ok, I've made some updates!

image

After installing the Caret Browsing extension (I'm on Chrome), I'm also seeing the issue you reported. I haven't found a fix yet, but hopefully I will. I don't think it's actually caused by the keyboard shortcuts, but more investigation is required. 🤷‍♂️

johnhyde commented 2 years ago

Added some welcome info, and made a few small fixes here and there. image