fix weird edge case bug by defaulting to rgba(0, 0, 0, 0), which is w…

yosoyubik / canvas

Peer-to-peer paint app for Urbit

MIT License

142 stars 9 forks source link

fix weird edge case bug by defaulting to rgba(0, 0, 0, 0), which is w… #31

Closed johnhyde closed 2 years ago

johnhyde commented 2 years ago

Default to rgba(0, 0, 0, 0), which is what d3 will give for any 0-opacity color. Without this, filling sometimes doesn't work as expected because 'rgba(0, 0, 0, 0)' != 'rgba(255, 255, 255, 0)'.

Sorry I didn't see this until after the release 😬

yosoyubik commented 2 years ago

LGTM!