yotamberk / timeline-plus

Timeline - chronological visualization of your data
MIT License
137 stars 36 forks source link

Fix events for labels of parent groups #153

Closed sbusch closed 5 years ago

sbusch commented 5 years ago

E.g. links can now be clicked in groups containing other groups, aswell.

Closes #140

Problem was the re-rendering of group labels for expanding/collapsing groups, which causes the originating event targets (e.g. links) to be removed from the DOM. The event now won't bubble up because there's no parent anymore (to my understanding). The timeout of 1 ms breaks the expand/collapse out of the event processing, which lets the browser finish the event processing before the DOM is being modified. Expand/collapse is performed after that, as soon as the browser is idle again.

Note: group still exands/collapses when clicked on the link, and this is quite noticeable for the user. But I found no way to prevent this behavior.

sbusch commented 5 years ago

PR based on wrong branch, sorry.