search

yotamberk / timeline-plus

Timeline - chronological visualization of your data
MIT License
137 stars 36 forks source link

replaced top, left right bounding rects to single function #160

Closed jarnovanrhijn closed 5 years ago

jarnovanrhijn commented 5 years ago

@yotamberk, added translate support for RTL and reversed textContent to innerHTML!

jarnovanrhijn commented 5 years ago

@yotamberk, Also replaced the tooltip because this.dom.content.style.left/right cannot be used anymore because of transforms :)

yotamberk commented 5 years ago

Awesome! I will go over all the examples to check that they are working fine and report back to you by the end of the week. Thank you again!

yotamberk commented 5 years ago

Hi @jarnovanrhijn , I've gone over all the examples and here are some issues that still need to be dealt with:

  1. example 'editingItemsinexample/editing` - notice the point item is stuck to the left and disappears when dragging the timeline at some point.
  2. example individualEditableItems in example/editing - notice the the item that is 'update group' while updating it's group causes it to disappear from the timeline until next render (e.g. moving timeline) , also notice the heights are recalculated but the item disappears.
  3. In general, moving items in editable mode causes glichiness when stacking. Updating items while stacking takes an extra render before the height of a group is properly calculated.
  4. expectedVsActualTimesItems.html is not working - might not be due to this PR...
  5. pointItems.html - point items are not positioned correctly (same as 1).
  6. tooltip.html in 'items' example is not working properly. Tooltips disappear after once.
  7. other/dataAttributes.html is not showing tooltips.
  8. drag&drop.html - when dragging a box item to group that is not the first one, the line is wrong.

It might have been that some of the issues mentioned above repeat themselves or are irrelevant to your changes but there are some that are definitely are related directly with your changes and I'd like you to fix them before I can accept this amazing and highly appreciated PR!! The main issues are 5 (point items are not working properly), 7 (tooltips stop working completely) and 3 (which seem to have whacky gliches since this PR)

jarnovanrhijn commented 5 years ago

Hi @jarnovanrhijn , I've gone over all the examples and here are some issues that still need to be dealt with:

  1. example 'editingItemsinexample/editing` - notice the point item is stuck to the left and disappears when dragging the timeline at some point.
  2. example individualEditableItems in example/editing - notice the the item that is 'update group' while updating it's group causes it to disappear from the timeline until next render (e.g. moving timeline) , also notice the heights are recalculated but the item disappears.
  3. In general, moving items in editable mode causes glichiness when stacking. Updating items while stacking takes an extra render before the height of a group is properly calculated.
  4. expectedVsActualTimesItems.html is not working - might not be due to this PR...
  5. pointItems.html - point items are not positioned correctly (same as 1).
  6. tooltip.html in 'items' example is not working properly. Tooltips disappear after once.
  7. other/dataAttributes.html is not showing tooltips.
  8. drag&drop.html - when dragging a box item to group that is not the first one, the line is wrong.

It might have been that some of the issues mentioned above repeat themselves or are irrelevant to your changes but there are some that are definitely are related directly with your changes and I'd like you to fix them before I can accept this amazing and highly appreciated PR!! The main issues are 5 (point items are not working properly), 7 (tooltips stop working completely) and 3 (which seem to have whacky gliches since this PR)

Points 1, (4 see below), 5 and 8 have been resolved. 4 had nothing to do with this PR. in Stack.js the function nostack is trying to call a function stackSubGroups which is a boolean. there is however a function stackSubgroups underneath the nostack function. i've renamed that function to stackedSubGroups and called it in the nostack function.

points 2, 3, 6 and 7 are yet to be resolved.

jarnovanrhijn commented 5 years ago

@yotamberk & fixed 6 and 7 as well. I've been looking at point 2 & 3. i've noticed that it only occurs with PointItems for some reason. not sure why tho.

jarnovanrhijn commented 5 years ago

@yotamberk Fixed number 2!

Number 3 is a bit strange becuase it is not happening all the time.. think it has something to do with timing.. not sure.. Could use some help identifying the problem.

yotamberk commented 5 years ago

Awesome. I'll take a look at 3. Great work!

yotamberk commented 5 years ago

F*** accidentally merged it to master... Can you please resubmit this PR? (I had to revert...)