Performance improvements

jarnovanrhijn commented 5 years ago

Great performance improvements

Replaced css left & top with translate()
Cached widths and heights where possible
Replaced new Date() with Date.now()

yotamberk commented 5 years ago

Sorry for the mistake...

jarnovanrhijn commented 5 years ago

@yotamberk haha no problem! I was happy to see it merged for a second because :P i thought you had fixed the glitching issue.

At least we have a fresh start in this PR ;)

yotamberk commented 5 years ago

I've been playing around with items/backgroundAreasWithGroups.html example dragging a ranged item to the far right near the the last items and playing around touching and untouching the dragged ranged item with the point item on the second group causes really weird behavior. It seems that something with the top calculation (now used with translateY?) might be causing the glitching and bad rendering. I've yet to figure it out exactly. I wanted to share this information while I continue to investigate.

NOTICE: changing the orientation option to top seems to work totally fine with not gliching.

Please continue to inspect the issue too so we can solve this and merge this GREAT pr!

yotamberk commented 5 years ago

Really awesome work! some of the best work done in this project in a long time!

yotamberk / timeline-plus

Performance improvements #168