search

yotamberk / timeline-plus

Timeline - chronological visualization of your data
MIT License
137 stars 36 forks source link

Infinite redraw with different zooms #175

Open lewisjb opened 5 years ago

lewisjb commented 5 years ago

Describe the bug When you are zoomed out, or in, the timeline keeps redrawing, increasing / decreasing by 1 or 2 pixels each redraw.

JSBin: https://output.jsbin.com/dawedivuse on zooms 125% and 75% (and probably others). If you can't reproduce it on those zooms, try others.

Expected behavior The redrawing the stabilize.

Browser Version 71.0.3578.98 (Official Build) (64-bit)

Additional context I dug into it a bit, it seems to be because of offsetHeight being wrong at different zooms. Here's a chromium bug report about it: https://bugs.chromium.org/p/chromium/issues/detail?id=608142 And here's another jsbin that just shows the offsetHeight issue, if you reload at different zooms you'll see it: https://jsbin.com/qegehiyini/edit?html,css,js,output

henrycjc commented 5 years ago

We also experience this issue, it is to do with the zoom level.

Any attention to this bug would be greatly appreciated

molkemon commented 5 years ago

DISREGARD THIS I AM DUMB. I did not have the css file loaded.... well that's two hours I'm never gonna get back, but in the rare event someone may be even remotely as dumb as me, that's your solution....

I am experiencing this issue aswell (with the soon to be merged timeline-plus). I don't have browser zoom on, what I am trying to do is load the timline inside a div within a DataTables Cell.

It flat out doesn't work, after getting item data via ajax the error message repeats itself a few times and then it just outputs "0" as text. No graph at all.