search

yotarok / flacenc-rs

FLAC encoder written in Rust
Apache License 2.0
22 stars 3 forks source link

Implemented last frame truncation. #205

Closed yotarok closed 2 months ago

yotarok commented 2 months ago

There is a design question whether this should be implenented as an optional behavior, or not. We think that this is okay to be forced-default because one can still avoid this behavior by implementing a custom Source type.

Closes #199.

dtzxporter commented 2 months ago

I tested this again and it's working great so far!

image

Checksum now matches and sample count does as well in 3rd party tools!

yotarok commented 2 months ago

A significant performance degradation observed on the "standard" benchmark machine (my x86_64 Linux desktop); however, rolling back this commit didn't help, and the results of the reference encoder were also degraded. I think this is due to an environmental change and this PR will be merged. We need to establish a way to run benchmarks in a publicly available machines (e.g. in Google Compute Engine) with a fixed environment.