you-apps / ClockYou

Privacy focused clock app built with MD3
https://you-apps.net
GNU General Public License v3.0
480 stars 33 forks source link

Ringtone preview doesn't stop after picking one #339

Closed Martysh12 closed 6 months ago

Martysh12 commented 6 months ago

Steps to reproduce

  1. Open a ringtone picker dialogue.
  2. Click on one of the ringtone preview buttons.
  3. Pick any ringtone, which closes the dialogue.
  4. The ringtone preview keeps ringing outside of the dialogue.

Expected behavior

The ringtone should stop ringing when I exit the ringtone picker dialogue.

Actual behavior

The ringtone continues ringing.

Clock You version

7.1

Android version

Android 13

Other details

Proposed fix: https://github.com/you-apps/ClockYou/blob/e6097b1659029d22a4dd9dc16b6ca6fc84639cc2/app/src/main/java/com/bnyro/clock/presentation/features/RingtonePickerDialog.kt#L100-L103 Add ringingToneModel.stopRinging(); to this block.

Acknowledgements

SuhasDissa commented 6 months ago

Use the latest version of the app (8.0)

Martysh12 commented 6 months ago

You're right, this bug doesn't happen in ClockYou 8.0. The latest version of ClockYou on F-Droid is 7.1, so I assumed it is the latest version. Closing this issue.