you-apps / ClockYou

Privacy focused clock app built with MD3
https://you-apps.net
GNU General Public License v3.0
471 stars 31 forks source link

Add support for dynamicSpot #76

Closed Myzel394 closed 1 year ago

Myzel394 commented 1 year ago

Describe your suggested feature

dynamicSpot is an app that allows Android users to create a Dynamic Island.

Using the native Google Clock, dynamicSpot works flawlessly, but with Clock You it doesn't.

Here's an example video:

out.webm

Other details

No response

Acknowledgements

Myzel394 commented 1 year ago

Btw, LibreTube does work with dynamicSpot

Bnyro commented 1 year ago

By LibreTube, you mean its player notification? DynamicSpot doesn't have any public details on how a notification must work that it's compatible, so I doubt we can do much here honestly.

Myzel394 commented 1 year ago

Exactly! Here's also a video of LibreTube in action with DynamicSpot:

out.webm

I think DynamicSpot doesn't use any special method to fetch the timers, LibreTube also doesn't use any special method to tell DynamicSpot that its playing videos - I guess Clock You just needs to tell Android natively that its running a timer somehow.

Bnyro commented 1 year ago

Hmm, I might have an idea for that

Bnyro commented 1 year ago

But it'll be some refactoring to implement, but I guess that's feasible

Bnyro commented 1 year ago

Please test a build from https://github.com/Bnyro/ClockYou/commit/318cd69fd31cfd44310e0972ad66b631548987e0, I'm confident that worked out.

Myzel394 commented 1 year ago

I'm sorry, but unfortunately it's still not working :/

I just realized that the Google Clock shows the timer duration (and also stopwatch btw) in real time in the notifications, while Clock You doesn't. How about we add the current remaining time (and stopwatch time) into the notification as well? Not only could this close this issue, but it's also much more useful in my opinion.

20230621_201704_temp

Bnyro commented 1 year ago

We did so before the commit. Doesn't it show in the stopwatch either?

Bnyro commented 1 year ago

And have you tested whether any other clock app on F-Droid works properly? (E.g. SimpleClock or https://www.f-droid.org/packages/com.best.deskclock/)

Myzel394 commented 1 year ago

We did so before the commit. Doesn't it show in the stopwatch either?

No it doesn't. Google's Clock uses the title to show the time, maybe that could solve the issue (I also think that's better generally btw)?

20230621_203750_temp

Myzel394 commented 1 year ago

@Bnyro I just tried SimpleClock and it does not work. So I guess DynamicSpot then probably has native support for Google's clock, what do you think?

Bnyro commented 1 year ago

Could you please try the desk clock too? It's almost the AOSP one (official one delivered by Google). If that doesn't work, there's no way we can add support for it.

Myzel394 commented 1 year ago

It did not work. I'll write the developer an email asking if they provide some way to add support for it then. Thanks for your help though :D