you-apps / RecordYou

Privacy focused recorder app built with MD3
https://you-apps.net
GNU General Public License v3.0
739 stars 30 forks source link

Improve landscape mode, Improve Audio Visualizer design #164

Closed SuhasDissa closed 1 year ago

SuhasDissa commented 1 year ago

This PR is pretty self-explanatory. The screenshots will show you what's new.


Bnyro commented 1 year ago

Looks great!

One thing though: Do we really need to use a constraint layout and can't just add a normal row/column where one component uses Modifier.weight(1f)? In my opinion we should try to keep things simple, and the new dependency is not really needed in my eyes.

So I'd just replace the constraintAs modifier and use a Row for landscape and a Column for portrait instead of a Box in ResponsiveRecordScreenLayout.

SuhasDissa commented 1 year ago

My initial plan was to do it like that. But Thought of using constraint layout for better flexibility. I too think thats a bit overkill for this simple scenario.

SuhasDissa commented 1 year ago