search

you-apps / RecordYou

Privacy focused recorder app built with MD3
https://you-apps.net
GNU General Public License v3.0
739 stars 30 forks source link

Add a simple audio / video trimmer. #178

Closed SuhasDissa closed 1 year ago

SuhasDissa commented 1 year ago

Hey! I was looking through the issue history of the app and saw that you closed issue #54 saying that it's not supported by Android system APIs. But I found a system API that does support simple video trimming, and the AOSP gallery app uses it without any third-party libraries.

I added that feature to the app, and it seems to work fine. There are a few minor front-end UI/UX issues that I'll fix soon. But in the meantime, I'd love for you to take a look and let me know what you think.

Thanks!

Bnyro commented 1 year ago

This looks great at first view! I haven't yet tested this, but such a functionality by using system APIs only is really awesome!

SuhasDissa commented 1 year ago

TrimmerModel has some problem. It doesn't reset the timestamps when opening a new file

SuhasDissa commented 1 year ago

image This is the only solution I could come up with

Bnyro commented 1 year ago

image This is the only solution I could come up with

That should be fine in my opinion. That way there's no edge case where startTimeStamp and endTimeStamp are not being resetted, so it's the probably the most safe option :)

SuhasDissa commented 1 year ago

@Bnyro What do you prefer? Merge or Squash and Merge

Bnyro commented 1 year ago

I combined the latest three commits since to clean up the commit history, now you can Merge the PR if you want :)