search

you-apps / RecordYou

Privacy focused recorder app built with MD3
https://you-apps.net
GNU General Public License v3.0
728 stars 30 forks source link

avoid using custom sample rate for OPUS #235

Closed SuhasDissa closed 8 months ago

SuhasDissa commented 8 months ago

fix #193

SilverPuppy commented 8 months ago

I don't believe this addresses the problem; in fact, it may make Opus completely unusable. Please reread the issue report this is meant to resolve. The issue is that the default sample rate gives poor results with Opus. The default needs to be adjusted for Opus, not locked in as non-adjustable. All of the CODECs are capable of strange results if someone enters a custom sample rate the CODEC doesn't support. The issue is that the default settings produce strange results in Opus.

Please consider adjusting this accordingly. I'm not sure what the default sample rate is, guessing 44,100, but if so, for Opus it should be 48,000. If this change is made, it will work by default, but people who wish to change it can. For example, I usually use 24,000 (another supported rate.) Losing the ability to change that would adversely affect me without helping anyone else. Most people who would change the sample rates have some idea of what should work.