search

you-apps / RecordYou

Privacy focused recorder app built with MD3
https://you-apps.net
GNU General Public License v3.0
750 stars 34 forks source link

Add bookmark feature #9

Closed xmha97 closed 1 year ago

xmha97 commented 1 year ago

Please add the bookmark feature and add the bookmarks to the MP3 file, (like the Samsung Voice Recorder app) Thanks.

serrq commented 1 year ago

I believe that mp3 doesn't support playing tagging. For sure .wav format can allows that feature, but mp3 I think no. Maybe dev can verify this.

Bnyro commented 1 year ago

I'm not sure of that, however I don't plan to add any bookmarking feature.

xmha97 commented 1 year ago

I'm not sure of that, however, I don't plan to add any bookmarking feature.

Hello @Bnyro I have reviewed many voice recorder apps. So far the best app I have seen is your app:

What I really need is a marker feature If you don't want to spend time on this feature, please reopen this issue so that people can see, discuss, and finally contribute.

As I said above, I tried many voice recorder apps, most apps have the marker feature, and the markers are stored in the app's database, not the file; This is not good because all markers will be lost when the app is uninstalled and installed.

I checked the Samsung voice recorder app, I don't really understand where the markers are stored in the file and it seems impossible to implement the Samsung method.

I checked the Windows 11 voice recorder app and believe it implemented the simplest and best method. This app saves markers in the Comments tag. Most audio formats also have this tag. I think this is a good method, please consider it.

image

image

Comments=23.44;22.36;21.24;20.12;18.72;17.28;16.16;15.56;14.92;13.68;12.16;10.44;8.72;6.6;3.28;

Sorry for my bad English. Thanks.

Wjxfi commented 1 year ago

interesting

Bnyro commented 1 year ago

I got your points and arguments, however I don't think this would fit the app well, even if someone else created a PR for it (I wouldn't reject it to not waste the work spent on it, but I'd prefer keeping the app simple). Adding support for it would require adding a third party dependency (if there even is one), and I don't think that fits the minimalism of the app well.