you-apps / TranslateYou

Privacy focused translator app built with MD3
https://you-apps.net
GNU General Public License v3.0
933 stars 41 forks source link

Add a search filter in the "Translation from Image" Tesseract data DL menu #434

Closed drogga closed 3 months ago

drogga commented 4 months ago

Describe your suggested feature

The Translation from Image doesn't have any search filter and eng.traineddata and the others are not easily locatable/noticeable, with their unfriendly naming and I'm not installing only 1 (ENg) engine, so it took me some time to find and DL what I needed.

Other details

I guess the Tesseract's files are download using the system's DL Manager, deleting them from there (system's "Files" app) removes them completely and I'm not sure that this is intended, I was expecting it to DL them internally and permanently store them in it's data cache, until that's cleared and not to be listed in or removable from the "Files" app, but that's a minor thing.

I don't think that it was necessary to create new issue ticket(s) for this, but I was instructed to do so in # 280 [Closed] (I'm not properly linking it on purpose), so here we are.

Acknowledgements

drogga commented 4 months ago

Oh and btw on small screens, that Tfi menu is super tiny at the bottom of the screen and extremely hard to use with that small scrollable window, because 75% of the screen is taken by the explanation text and unnecessary empty/blank UI spaces, the huge top and bottom paddings are unnecessary and the margins should be reduced, overall the UI/UX needs a lot of work in order to be actually usable, that TSS/Tfi menu should be more like the "Translate to" (language picker) one, ideally as a pop-up dialog.

drogga commented 3 months ago

@Bnyro Why doesn't the search filter clear the query when going back ?, because it definitely should and not only in this "Translation from Image" menu, but globally, wherever is a search filter in the app. The text on top is selectable, but why isn't the link https://github.com/tesseract-ocr/tessdata a clickable link ?, also it's unnecessarily huge if you boosted/increased the font size globally from the system settings, which caused the list to be barely visible.

There are 3 engines with a option for "Selected engine", but there's no indication whatsoever which one is actually and currently selected in that pop-up dialog, no highlighting or a checkmark symbol like in "App language" - nothing, so how I'm supposed to tell which one is currently being used from those lists ?, at least the ones in the top buttons are super easy to tell what is selected...

I see that You didn't bother to address the thing under "Other details" in the OP here...

Can't the /releases assets files be named properly with the ver. in the filename like "TranslateYou_v10.0.apk", instead of "app-release.apk" ?, which is super misleading and confusing in someone's DL folder when you keep multiple versions or have other apps named the same with only a number in brackets that the browser/DLer attaches to avoid overwriting (or be overwritten automatically, depending the preferences), anyway it makes 0 sense to me to be named in such a generic way for every new ver. in so many other repos as well.