search

you-apps / WallYou

Privacy focused wallpaper app built with MD3
https://you-apps.net
GNU General Public License v3.0
664 stars 33 forks source link

fix: Low res wallpaper loading #131

Closed SuhasDissa closed 1 year ago

SuhasDissa commented 1 year ago

This might fix #127

I couldn't figure out a way a way to test this.

I think this bug was caused by the change to using the Exif thumbnail instead of the full-sized bitmap here.

I had to use a FileDescriptor instead of an InputStream because the input stream can't be used more than once (AFAIK).

SuhasDissa commented 1 year ago

I wonder if this really changes something, but we'll see 🤔

According to Wikipedia, the EXIF thumbnail has a lower quality and resolution compared to the original image. This is because EXIF thumbnails are designed to be small and fast-loading.

The EXIF thumbnail is typically about 160x120 pixels in resolution, and it is compressed using the JPEG format. This compression can reduce the file size of the thumbnail by up to 10 times, but it can also reduce the quality of the image.

SuhasDissa commented 1 year ago

I tested this on my phone, and didn't notice any resolution issue in the applied wallpapers.

Bnyro commented 1 year ago

Thanks for the infos, I didn't know EXIF was meant to be fast and small in size. Sounds reasonable that this will fix it :+1: