Closed cylim closed 5 years ago
Test failed due to it is using a different alpha version of date-fns
, should we fix the version until the official release?
@cylim in our project, we use 2.X api from date-fns.
@cylim in our project, we use 2.X api from date-fns.
@cylim We are using 2.X of date-fns.
@cht8687 currently, date-fns:2.x
is in alpha release, that's the reason for the test fail, do you recommend to fix a version or to fix the unit test along the journey?
@cht8687 currently, date-fns:2.x
is in alpha release, that's the reason for the test fail, do you recommend to fix a version or to fix the unit test along the journey?
Doesn't sure what is the best way to test this. According to date-fns docs, the way they format it is 1 month
, 1 day
, 1 year
instead of a month
, a day
, a year
(momentjs is using).
@cht8687 fix the relative time to 3 months. It is not a bug for the test case, but a different library decided to present the relative time in different ways.
1 month, 1 day, 1 year
a month, a day, a year
For the detailed comparison, need to understand how we should show for the output: #55
This merge request is requested by #26