search

you-dont-need / You-Dont-Need-Momentjs

List of functions which you can use to replace moment.js + ESLint Plugin
MIT License
13.27k stars 318 forks source link

Add native implementation of format #83

Closed Amorymeltzer closed 2 years ago

Amorymeltzer commented 4 years ago

Closes #60

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 204

Totals Coverage Status
Change from base Build 203: 0.0%
Covered Lines: 43
Relevant Lines: 43
💛 - Coveralls
coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 217

Totals Coverage Status
Change from base Build 216: 0.0%
Covered Lines: 43
Relevant Lines: 43
💛 - Coveralls
Amorymeltzer commented 4 years ago

I think failures on node 8 are related to not having full intl support, see: https://github.com/nodejs/node/issues/8500 and https://github.com/nodejs/node/issues/19214.

Not sure if specifying en-US would fix that.

stevemao commented 4 years ago

@cylim Yes good idea :)

cht8687 commented 4 years ago

could you resolve the conflicts? so that we can merge

Amorymeltzer commented 4 years ago

@cht8687 Done; apologies for not doing so earlier, I had thought this stalled waiting for removal of node 8

Amorymeltzer commented 2 years ago

Conflict comes from #116, which largely (though not equivalently?) supersedes this