youcef92 / flotr

Automatically exported from code.google.com/p/flotr
0 stars 0 forks source link

Mixed EOL styles #128

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I feel a bit silly for posting this as an issue, but it's really annoying
so here goes:

Some lines are terminated by UNIX newlines (a single \n) while some are
terminated by DOS newlines (\r\n)

This is a rather annoying when trying to provide patches, view diffs or
even in some cases when editing (I guess you have a smarter editor than I
do, mine shows the \r as ^M) It could be solved pretty easily by getting
rid of all the extra \r signs (subversion should auto-convert the \n
newlines to \r\n when a checkout is made under Windows, and it should
auto-convert back when committing on Windows)

Original issue reported on code.google.com by peter....@solide-ict.nl on 3 Jun 2010 at 7:46

GoogleCodeExporter commented 8 years ago
I also noticed there is mixed use of tabs and spaces for indentation. This is 
also
rather annoying when the number of spaces used to indent doesn't match the 
tabsize
you set in your editor. See also http://www.emacswiki.org/emacs/TabsAreEvil :)

Original comment by peter....@solide-ict.nl on 3 Jun 2010 at 8:57

GoogleCodeExporter commented 8 years ago
Hey, this is now fixed, I changed the tabs to spaces (I didn't have any 
preference for tabs, it's just the project was originally with tabs). I also 
set the svn:eol-style property to LF (Unix).

Original comment by fabien.menager on 21 Jun 2010 at 9:47