youdz / d2-stash-organizer

Diablo 2 Collection manager
MIT License
59 stars 21 forks source link

Bloodletter perfection calculation is wrong #6

Closed ChaosMarc closed 3 years ago

ChaosMarc commented 3 years ago

I have several Bloodletter swords in my stash. one of them is perfect (the others vary in quality) but your organizr just shows 75% for all of them. I've attached my stash for testing purposes: _LOD_SharedStashSave.zip

image Screenshot002

youdz commented 3 years ago

I just tested, confirmed fix is part of https://github.com/youdz/d2-stash-organizer/commit/3635b10404a7c95d8708e5bb349357b0076639cb, it now looks like this when running locally with the fix:

Screen Shot 2021-07-24 at 12 12 41

The only problem is that I kind of want to get the UI refactor somewhat stable before releasing. Doesn't need to have a ton of new features, just working and without regressions is what I'm looking for right now. Hopefully it works this week-end, otherwise I'll go back and release the fix by itself pre-refactor.

ChaosMarc commented 3 years ago

No worries. Take all the time you need. I just wanted to notify you about the issue. I'm really looking forward to your next release 👍

youdz commented 3 years ago

Little teaser to thank you for your patience:

Screen Shot 2021-07-24 at 17 18 39

The display is nice, but the real value is the ability to now search "faster cast rate" and get the list of all equipments with FCR.

ChaosMarc commented 3 years ago

Thanks for that :) that's one of the most important things I was missing in the current version :) one suggestion though: displaying the min max values of the Stats that factor into the perfection calculation would be awesome. Just display them in brackets behind the actual value. I think some maphack had this feature and I really liked it.

youdz commented 3 years ago

There you go, this bug is fixed.

The UI refactor is now up, and the only real feature it added for now is searchable item mods (I guess it's a pretty big one). But at least it sets up easier features for filtering and sorting, for the organizer and for the grail tracker.

Next, I'd really like to improve the base item display, right now this dump of whatever feels useful to display inline is... awkward.

I'm making a note of the range thing, I do agree it'd be useful.