yougov / velociraptor

BSD 3-Clause "New" or "Revised" License
11 stars 1 forks source link

Stale buildpacks #110

Closed ghost closed 8 years ago

ghost commented 10 years ago

Originally reported by: Brent Tubbs (Bitbucket: btubbs, GitHub: btubbs)


Velociraptor's git and hg support is implemented in vr.common.repo. Using the Repo class found there, you must supply a revision string when calling .update() to check out a particular version of a repo.

Buildpacks aren't normally tagged, so the practice with them is normally to just check out the latest version. So the Buildpack class (a subclass of Repo), uses a default of 'HEAD' as the revision.

When the Git flavor of .update() used 'git pull', this was sufficient to pull all changes to a buildpack into the working directory. However, now that .update() is implemented with 'git fetch' plus 'git checkout ', changes to buildpacks are no longer brought into the working directory.

root@vybuild3:/apps/builder/buildpacks/heroku-buildpack-hello-2d4689cf7abfc318f1f56a0f66c7d1d3# git checkout HEAD
Your branch is behind 'origin/master' by 1 commit, and can be fast-forwarded.

ghost commented 10 years ago

Original comment by Brent Tubbs (Bitbucket: btubbs, GitHub: btubbs):


explicitly checkout origin/master when updating a buildpack. fix issue 110