search

yougov / velociraptor

BSD 3-Clause "New" or "Revised" License
11 stars 1 forks source link

Invoking a build through the CLI ignores stack #189

Closed ghost closed 8 years ago

ghost commented 8 years ago

Originally reported by: Jason R. Coombs (Bitbucket: jaraco, GitHub: jaraco)

If one invokes a build through the command-line interface (vr.cli), the build will not honor the stack configured for the app, and will attempt to build the app as a non-containerized app. This behavior is observed because the other methods that build apps (through the web UI or internally via swarms), are expected to relay the container setting from the App model to the build function.

The short term workaround would be to adapt the vr.cli to additionally load and relay the stack setting when invoking a build.

A better workaround would be for any build command to resolve the stack directly for any build.

ghost commented 8 years ago

Original comment by Jason R. Coombs (Bitbucket: jaraco, GitHub: jaraco):

That's fantastic. Thanks!

ghost commented 8 years ago

Original comment by Lorenzo Bolla (Bitbucket: lbolla, GitHub: lbolla):

Fixed in https://bitbucket.org/yougov/vr.server/commits/f3bfc37f5137f0fda0116c43b04e7599fe48f80f