search

yougov / velociraptor

BSD 3-Clause "New" or "Revised" License
11 stars 1 forks source link

Test failures in clean_host tests. #202

Closed ghost closed 8 years ago

ghost commented 8 years ago

Originally reported by: Jason R. Coombs (Bitbucket: jaraco, GitHub: jaraco)

Tests in CI are failing and there are no passing tests in the history.

Going back to build 102 and through build 115, I see one test failure in test_clean_images_folders.

Starting in build 116, a new test failure emerges in test_clean_host.

ghost commented 8 years ago

Original comment by Lorenzo Bolla (Bitbucket: lbolla, GitHub: lbolla):

Fixed. I had to mock some calls to fabric that caused it to prompt for hostname, hence making the test fail.

ghost commented 8 years ago

Original comment by Jason R. Coombs (Bitbucket: jaraco, GitHub: jaraco):

I've marked the tests as xfail so they're no longer breaking the build. Lorenzo, would you look into why the tests were failing?

ghost commented 8 years ago

Original comment by Jason R. Coombs (Bitbucket: jaraco, GitHub: jaraco):

The build against the 5.2.2 tag failed because drone only builds against branches, not tags.

But I found the issue - Celery 4 drops support for e-mail notifications, and the setup of those notifications causes the tests to fail. That's been fixed.

ghost commented 8 years ago

Original comment by Jason R. Coombs (Bitbucket: jaraco, GitHub: jaraco):

Then, in build 126, the entire test suite starts to fail, not apparently due to the changes in the push, so in build 127, I'm rebuilding the 5.2.2 tag to see if it fails also.