youhosi / nodebb-theme-oxide

Theme based on Github for NodeBB.
MIT License
23 stars 19 forks source link

(Option to) show all badges on the post and profile by default #8

Closed tom-rade closed 5 years ago

tom-rade commented 5 years ago

According to this issue, the displaying of all badges next to posts and on the profile is possible:

https://github.com/NodeBB/NodeBB/issues/7180 "Display of badges is controlled at the theme level, themes can elect to show all badges, as the data is (or should be, anyway) available for use in templates."

So technically, it should be possible to implement it that way. I'd very much appreciate it and this is the only thing needed for us to switch to this theme.

youhosi commented 5 years ago

@tom-rade Adding a few badges can cause the style to be displayed badly on mobile devices. But adding them to the user profile would not be a major problem.

tom-rade commented 5 years ago

@youhosi I understand, but add the option in the settings please. On my forum, most people have 2-3 groups which wouldn't cause style issues. And I can't go into each of the 500 users and select badges.

youhosi commented 5 years ago

@tom-rade Style allows you to set multiple tags, most likely you did not do it in the group settings (allow multiple bagdes)

zrzut ekranu z 2019-01-06 20-03-33 zrzut ekranu z 2019-01-06 20-03-19

tom-rade commented 5 years ago

@youhosi Yes I know, I set multiple badges. But as a user, I have to select MANUALLY which badges are shown - but I want all badges to be shown.

youhosi commented 5 years ago

@tom-rade Only where I can display all groups is the profile view.

tom-rade commented 5 years ago

@youhosi Are you sure about that? Cause theoretically you just copy the template from the group list in profile to the posts. And then edit the style.

youhosi commented 5 years ago

@tom-rade Yes, or I do not know / saw a function that could do it, unfortunately NodeBB has a lot of limits for themes.

youhosi commented 5 years ago

this:

                <!-- BEGIN groups -->
                <a href="{config.relative_path}/groups/{groups.slug}">
                    <span class="label group-label inline-block" style="background-color: {groups.labelColor};">
                        <!-- IF groups.icon --><i class="fa {groups.icon}"></i> <!-- ENDIF groups.icon -->{groups.userTitle}
                    </span>
                </a>
                <!-- END groups -->

It will no longer work in the posts view.

tom-rade commented 5 years ago

@youhosi Hmm interesting. Ok thanks anyways.