youhosi / nodebb-theme-oxide

Theme based on Github for NodeBB.
MIT License
23 stars 19 forks source link

Change color of light gray description and other small texts #9

Closed tom-rade closed 5 years ago

tom-rade commented 5 years ago

The only other thing bothering me, is the colors of descriptions and small texts. For example:

[component="category"] .category-details .content .show-separator .description {
    font-size: 12px;
    color: #bbb;
}

#bbb is way too light on most displays causing the user to barely read anything. Some other CSS classes where it's too light: .categories-title .breadcrumb .categories .category-details

youhosi commented 5 years ago

@tom-rade In which case, what color would be appropriate in your opinion?

tom-rade commented 5 years ago

@youhosi Something like #303030 or maybe a tad lighter with #444444

youhosi commented 5 years ago

@tom-rade #303030 and #444444 is too dark and would stand out too much in the template.

tom-rade commented 5 years ago

@youhosi Hmm yeah, the theme is indeed pretty light. But most #bbb classes should be changed so it gets normalized. Otherwise I'd try using #7c7c7c, that would still be more readable than #bbb. But #bbb is way too light and unreadable.

youhosi commented 5 years ago

@tom-rade To set a darker color in these classes, the whole style would have to be adapted from the beginning.

@gray-base:              #444444;
@gray-darker:            lighten(@gray-base, 13.5%); // #666
@gray-dark:              lighten(@gray-base, 20%); // #777
@gray:                   lighten(@gray-base, 33.5%); // #999
@gray-light:             lighten(@gray-base, 37%); // lighten(@gray-base, 46.7%); // #bbbbbb
@gray-lighter:           lighten(@gray-base, 65%); // #eaeaea
tom-rade commented 5 years ago

@youhosi Yep, but I find it is necessary. #bbb is waaaay too light. Text should be black (even here on GitHub, on a light theme - it's black) - not gray.

youhosi commented 5 years ago

@tom-rade All in all a fact, so you will need to work on the color style. Do you have any suggestions regarding colors? Take into account that they also can not stand out too much from the rest of the elements.

I also thought about adding an underline when hovering on a link.