Closed cgwalters closed 2 months ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.71%. Comparing base (
57570dd
) to head (6f7eefb
). Report is 37 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Originally I only implemented
FromStr
but havingTryFrom
for both&str
andString
too seems also idiomatic. Notably it's done byReference
, also in this crate.That said there was a lot of debate in e.g. https://users.rust-lang.org/t/is-there-actually-a-semantic-difference-between-fromstr-and-tryfrom-str/92765/15
But...these things are strings more than they're not, so arguably indeed
TryFrom<string type>
makes sense.