youki-dev / oci-spec-rs

OCI Runtime, Image and Distribution Spec in Rust
https://crates.io/crates/oci-spec
Apache License 2.0
218 stars 52 forks source link

Increase regex version constraint compatibility #234

Closed kpcyrd closed 1 month ago

kpcyrd commented 1 month ago

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

The current version constraint causes issues, specifying a dependency of 1 indicates compatibility with any other 1.*.* version of the regex crate, which I think is the case here.

This is related to discussion in https://github.com/containers/oci-spec-rs/issues/190#issuecomment-2383800512

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Thanks!

Does this PR introduce a user-facing change?

None
codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 29.02%. Comparing base (57570dd) to head (957503c). Report is 58 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #234 +/- ## ========================================== + Coverage 26.61% 29.02% +2.41% ========================================== Files 24 26 +2 Lines 2788 3159 +371 Branches 1516 1671 +155 ========================================== + Hits 742 917 +175 - Misses 948 1021 +73 - Partials 1098 1221 +123 ```
saschagrunert commented 1 month ago

@kpcyrd do you mind a rebase?

kpcyrd commented 1 month ago

Done!

kpcyrd commented 2 weeks ago

Could you please release a new version? :) the latest version on crates.io still breaks cargo outdated -R for my project.

saschagrunert commented 2 weeks ago

Could you please release a new version? :) the latest version on crates.io still breaks cargo outdated -R for my project.

Yeah: https://github.com/youki-dev/oci-spec-rs/pull/253