search

youki-dev / youki

A container runtime written in Rust
https://youki-dev.github.io/youki/
Apache License 2.0
6.28k stars 344 forks source link

Cargo.toml: remove unused dependnecies #2921

Closed Mossaka closed 1 month ago

Mossaka commented 1 month ago

remove unused deps in youki, found by running cargo machete

question: perhaps we should consider adding this to the CI?

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.76%. Comparing base (ea96160) to head (b70efdc). Report is 14 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2921 +/- ## ======================================= Coverage 66.76% 66.76% ======================================= Files 131 131 Lines 16673 16673 ======================================= Hits 11131 11131 Misses 5542 5542 ```
utam0k commented 1 month ago

question: perhaps we should consider adding this to the CI?

I didn't know that. Exactly. Do you have an intention to contribute?

Mossaka commented 3 weeks ago

@utam0k I just realized that my PR removed a pinned version of protobuf. Can you evaluate if that's needed? https://github.com/containers/youki/pull/2921/files#diff-05eb4a3f83693cfbdc185e744c79b31a56b710583017eb128a83fc9dfaf64561L51

utam0k commented 3 weeks ago

@Mossaka I've left my comment on here. https://github.com/containers/youki/pull/2497#issuecomment-2395709055