youki-dev / youki

A container runtime written in Rust
https://youki-dev.github.io/youki/
Apache License 2.0
6.28k stars 344 forks source link

Add seccomp into feature flags of youki to be compiled in #2924

Closed musaprg closed 3 weeks ago

musaprg commented 1 month ago

Currently, the youki disables the libcontainer/libseccomp feature by setting default-feature = false. If libcontainer has a feature flag for seccomp, youki should also have the feature flag so that we can use it by enabling it through the build option.

Since I'm new to this project, I don't have enough background and status of seccomp support in youki. Please let me know if there's any reason why this feature is explicitly disabled in youki, for example, it's still an experimental feature.

yihuaf commented 1 month ago

In short, not all platform supports libseccomp. There are some context in these issues and MR. Please read them and I can help answer further questions :)

utam0k commented 1 month ago

May I ask you to check CI?

musaprg commented 1 month ago

Hi. I rechecked and fixed my changes to the test cases. Could you check it again? Thanks.