search

youknowone / itunes-iap

Apple iTunes In-app purchase verification tool
http://itunes-iap.readthedocs.io
Other
136 stars 50 forks source link

Add new properties on the InApp object #19

Closed dlm closed 8 years ago

dlm commented 8 years ago

In the new format, Apple added some nice methods for processing dates (the dates are provided with number of milliseconds since epoch). Also added a boolean for 'is_trial_period'

dlm commented 8 years ago

I think that I figured out and resolved the problems (style errors with flake 8). Other than that, I am stumped why it failed. Any ideas?

youknowone commented 8 years ago

You can check the result by clicking red X mark to seee that. https://travis-ci.org/youknowone/itunes-iap/jobs/89988370

So, 

./tests/v2_test.py:194:39: E261 at least two spaces before inline comment

This project is not checking 80col rules.

Can I suggest to rebase your patches? Because it is conceptionally one patch and other technical fixings.

If you added my repo as youknowone, (like git remote add youknowone https://github.com/youknowone/itunes-iap

git fetch youknowone
git rebase youknowone/master

will remove the merge commit bdb2632.

About other commits,

git rebase -i youknowone/master

will shows interactive rebase interface. You can mark all of trivial fixings as squash to squash them to your main commit.

youknowone commented 8 years ago

Subset of #20