youknowone / itunes-iap

Apple iTunes In-app purchase verification tool
http://itunes-iap.readthedocs.io
Other
136 stars 50 forks source link

Support exclude-old-transactions Request parameter #39

Closed brandon-clair closed 7 years ago

brandon-clair commented 7 years ago

This adds support for sending the exclude-old-transactions Request parameter to App Store receipt validation.

Apple Docs https://developer.apple.com/library/content/releasenotes/General/ValidateAppStoreReceipt/Chapters/ValidateRemotely.html

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 88.657% when pulling b5e2fb7adb1fb316c5309bb23f41441d3b82c935 on brandon-clair:master into 16ade8ec2bc233c8f1a99e8e31da9c36d01e6759 on youknowone:master.

codecov[bot] commented 7 years ago

Codecov Report

Merging #39 into master will increase coverage by 0.03%. The diff coverage is 75%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   88.62%   88.66%   +0.03%     
==========================================
  Files           8        8              
  Lines         334      335       +1     
==========================================
+ Hits          296      297       +1     
  Misses         38       38
youknowone commented 7 years ago

Thanks for the new feature support. Can you add test for it? The test needs to cover both of True and False cases.

To make the change clear: the response format was not changed, right?

brandon-clair commented 7 years ago

@youknowone A test has been added! Since the parameter is optional, and defaults to False, the current suite of tests cover that case. I have added a case where the parameter is submitted as True.

Correct, the response format has not been altered. This is to support a new, optional parameter for verification requests, exclude-old-transactions.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 88.657% when pulling 7c7e174ad08b3b2af17ff8305f6f8e7c4ff9057e on brandon-clair:master into 16ade8ec2bc233c8f1a99e8e31da9c36d01e6759 on youknowone:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 88.657% when pulling 7c7e174ad08b3b2af17ff8305f6f8e7c4ff9057e on brandon-clair:master into 16ade8ec2bc233c8f1a99e8e31da9c36d01e6759 on youknowone:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 88.657% when pulling 7c7e174ad08b3b2af17ff8305f6f8e7c4ff9057e on brandon-clair:master into 16ade8ec2bc233c8f1a99e8e31da9c36d01e6759 on youknowone:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 88.657% when pulling 7c7e174ad08b3b2af17ff8305f6f8e7c4ff9057e on brandon-clair:master into 16ade8ec2bc233c8f1a99e8e31da9c36d01e6759 on youknowone:master.

youknowone commented 7 years ago

I merged it, thanks!