youknowone / itunes-iap

Apple iTunes In-app purchase verification tool
http://itunes-iap.readthedocs.io
Other
136 stars 50 forks source link

Is pyOpenSSL needed for latest Python versions? #56

Closed stephen-liu-storymotions closed 6 years ago

stephen-liu-storymotions commented 6 years ago

I believe that requests library with the security extras are not needed for the latest Python versions: https://pyopenssl.org/en/stable/introduction.html#history

pipenv for example has this in its setup.py: 'requests[security];python_version<"2.7"'

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 95.197% when pulling 23ce4577671634a620cffba70bb4663f46e3a45f on stephen-liu-storymotions:patch-1 into 99ef56b23d144a26beb5f25dd9e51a52db00743e on youknowone:master.

codecov[bot] commented 6 years ago

Codecov Report

Merging #56 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #56   +/-   ##
======================================
  Coverage    95.2%   95.2%           
======================================
  Files          11      11           
  Lines         458     458           
======================================
  Hits          436     436           
  Misses         22      22
youknowone commented 6 years ago

Thanks!